Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Improve CBA_fnc_addItem, Fix CBA_fnc_addMagazine return #1562

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Nov 24, 2022

When merged this pull request will:

Improve CBA_fnc_addItem
If the unit doesn't have enough space then try to add the item to the unit's vehicle instead of always chucking it out the window onto the ground where it gets lost.

Attempt to add the item to the unit's vehicle instead of always chucking it out the window onto the ground.
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes rv from false to true when dropping items on the ground as far as I can tell.

@Drofseh
Copy link
Contributor Author

Drofseh commented Nov 24, 2022

Changes rv from false to true when dropping items on the ground as far as I can tell.

Should change it from always returning false to returning whatever CBA_fnc_addItemCargo returns if it is called, so true if it went somewhere basically.
Ok with to change that back if you'd prefer, but this is the same behaviour that CBA_fnc_addMagazine currently has

@commy2
Copy link
Contributor

commy2 commented Nov 25, 2022

Yes, because it breaks the behaviour documented in the functions header, and then also fix #1527

@Drofseh
Copy link
Contributor Author

Drofseh commented Nov 25, 2022

Done and done

@Drofseh Drofseh changed the title Common - Improve CBA_fnc_addItem Common - Improve CBA_fnc_addItem, fix CBA_fnc_addMagazine return Nov 25, 2022
@jonpas jonpas changed the title Common - Improve CBA_fnc_addItem, fix CBA_fnc_addMagazine return Common - Improve CBA_fnc_addItem, Fix CBA_fnc_addMagazine return Jun 24, 2023
@jonpas jonpas merged commit 4ee49d4 into CBATeam:master Jun 24, 2023
@jonpas jonpas added this to the 3.15.9 milestone Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants